Skip to content

[ENH] - Add triangle periodic fit mode #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ENH] - Add triangle periodic fit mode #376

wants to merge 5 commits into from
+68 −14

Conversation

@TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Nov 18, 2025 •
edited
Loading

This adds a new "triangle" periodic fit mode.

Notes:

  • The currently defined 'triangle' is a symmetric triangle or sawtooth shape
  • It's defined to match the parameters of the gaussian (CF, PW, BW)
  • However, there appear to be some quirks with using this in the existing fitting mode (e.g. bandwidth guesses don't seem great) such that it doesn't seem to end up on ideal solutions
  • Currently, this mode should be considered experimental

@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (19e9cbb) to head (af14988).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         152      152           
  Lines        6476     6491   +15     
=======================================
+ Hits         6320     6335   +15     
  Misses        156      156

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomDonoghue